Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helpers): using translated name props #1246 #1262

Merged
merged 8 commits into from
Dec 1, 2020

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Nov 29, 2020

Changes

closes #1246

Checklist

@vercel
Copy link

vercel bot commented Nov 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/qvski35l3
✅ Preview: https://shopware-pwa-docs-git-feat-using-translated-props-1246.shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview November 29, 2020 22:38 Inactive
@github-actions
Copy link

github-actions bot commented Nov 29, 2020

💙 shopware-pwa-canary successfully deployed at https://95c0d96b3b0b0d42ea0d98cac173250b46611861.shopware-pwa-canary.preview.storefrontcloud.io

@mkucmus mkucmus marked this pull request as ready for review December 1, 2020 08:56
@vercel vercel bot temporarily deployed to preview December 1, 2020 08:56 Inactive
@mkucmus mkucmus changed the title [WIP] feat(helpers): using translated props #1246 feat(helpers): using translated name props #1246 Dec 1, 2020
@vercel vercel bot temporarily deployed to preview December 1, 2020 13:17 Inactive
@vercel vercel bot temporarily deployed to preview December 1, 2020 13:21 Inactive
@vercel vercel bot temporarily deployed to preview December 1, 2020 13:48 Inactive
@mkucmus mkucmus merged commit 6dc6627 into master Dec 1, 2020
@mkucmus mkucmus deleted the feat/using-translated-props-#1246 branch December 1, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] always use translated object to get the text fields' value
1 participant